Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v8): do not ignore failures when running git #809

Merged
merged 1 commit into from
May 21, 2024
Merged

fix(v8): do not ignore failures when running git #809

merged 1 commit into from
May 21, 2024

Conversation

targos
Copy link
Member

@targos targos commented May 12, 2024

Also always use forceRunAsync because runAsync exits the process on error.

@targos
fix(v8): do not ignore failures when running git
a8138d4 
Also always use `forceRunAsync` because `runAsync` exits the process on error.
@targos targos mentioned this pull request May 12, 2024
Open
@targos
Copy link
Member Author

targos commented May 18, 2024

@nodejs/node-core-utils

aduh95
aduh95 approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to test it, but the code diff looks all right

@targos
Copy link
Member Author

targos commented May 21, 2024

I tested these scenarios locally:

  • Major update
  • Minor update (already up-to-date)
  • Minor update (with patch)
  • Backport (patch applies cleanly)
  • Backpor (patch doesn't apply cleanly)

@targos targos merged commit 9f8df53 into nodejs:main May 21, 2024
11 checks passed
@targos targos deleted the run-async branch May 21, 2024 13:54
@github-actions github-actions bot mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@targos @aduh95