Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git-node): allow empty commits with fixupAll #681

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 8, 2023

Fixes: #619

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (81d53a2) 83.40% compared to head (6cc8da2) 83.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #681   +/-   ##
=======================================
  Coverage   83.40%   83.40%           
=======================================
  Files          37       37           
  Lines        4146     4146           
=======================================
  Hits         3458     3458           
  Misses        688      688           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aduh95 aduh95 changed the title feat(land): allow empty commits with fixupAll feat(git-node): allow empty commits with fixupAll Mar 8, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 18, 2023

ping @nodejs/node-core-utils

@aduh95 aduh95 merged commit e0d6d0d into nodejs:main Mar 18, 2023
@aduh95 aduh95 deleted the allow-empty-fixupAll branch March 18, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't handle empty commit even by cli
2 participants