Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross version tests broken #548

Closed
mhdawson opened this issue Sep 23, 2019 · 5 comments
Closed

Cross version tests broken #548

mhdawson opened this issue Sep 23, 2019 · 5 comments

Comments

@mhdawson
Copy link
Member

We have a bunch of failures in the testing across verions. Believe this must have been the commit that caused it:

#534

@mhdawson
Copy link
Member Author

CI run which shows failures: https://ci.nodejs.org/job/node-test-node-addon-api-new/639/

@mhdawson
Copy link
Member Author

mhdawson commented Sep 23, 2019

failures

 CXX(target) Release/obj.target/binding/basic_types/number.o
  CXX(target) Release/obj.target/binding/basic_types/value.o
  CXX(target) Release/obj.target/binding/bigint.o
  CXX(target) Release/obj.target/binding/date.o
  CXX(target) Release/obj.target/binding/binding.o
  CXX(target) Release/obj.target/binding/buffer.o
In file included from /data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi.h:2082:0,
                 from ../date.cc:2:
/data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi-inl.h: In member function ‘bool Napi::Value::IsDate() const’:
/data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi-inl.h:389:58: error: ‘napi_is_date’ was not declared in this scope
   napi_status status = napi_is_date(_env, _value, &result);
                                                          ^
In file included from /data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi.h:2082:0,
                 from ../date.cc:2:
/data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi-inl.h: In static member function ‘static Napi::Date Napi::Date::New(napi_env, double)’:
/data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi-inl.h:683:57: error: ‘napi_create_date’ was not declared in this scope
   napi_status status = napi_create_date(env, val, &value);
                                                         ^
/data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi-inl.h: In member function ‘double Napi::Date::ValueOf() const’:
/data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi-inl.h:701:28: error: ‘napi_get_date_value’ was not declared in this scope
       _env, _value, &result);
                            ^
binding.target.mk:159: recipe for target 'Release/obj.target/binding/date.o' failed
make: *** [Release/obj.target/binding/date.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from /data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi.h:2082:0,
                 from ../bigint.cc:2:
/data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi-inl.h: In member function ‘bool Napi::Value::IsDate() const’:
/data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi-inl.h:389:58: error: ‘napi_is_date’ was not declared in this scope
   napi_status status = napi_is_date(_env, _value, &result);
                                                          ^
In file included from /data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi.h:2082:0,
                 from ../bigint.cc:2:
/data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi-inl.h: In static member function ‘static Napi::Date Napi::Date::New(napi_env, double)’:
/data/iojs/build/workspace/node-test-node-addon-api-new/nodes/rhel72-s390x/node-addon-api/napi-inl.h:683:57: error: ‘napi_create_date’ was not declared in this scope
   napi_status status = napi_create_date(env, val, &value);

@mhdawson
Copy link
Member Author

I think I may have broken when I did a nightly last week. I used v8.x instead of v8.x-staging which would have removed some of the functions which have not yet landed as experimental.

New nightly to try to resolve: https://ci-release.nodejs.org/job/iojs+release/4698/

@mhdawson
Copy link
Member Author

Ok, new 10.x nightly seems to have fixed 10.x

Full cross version run here: https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/484/

@mhdawson
Copy link
Member Author

Ok all runs were green, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant