Why don't my asynchronous callbacks work?

[kkoopa]

Trying to adapt node-snappy for NAN, I cannot get the asynchronous callbacks to work. All asynchronous tests fail with 'Callback not called', where all synchronous tests pass. What am I doing wrong?

kkoopa/node-snappy@kesla:master...master

[rvagg]

oh, cause we have a bug in NanCallback#GetFunction() I think. Assign the Function as:

v8::Local<v8::Object> obj = v8::Object::New();
obj->Set(NanSymbol("callback"), fn);
NanAssignPersistent(v8::Object, handle, obj); 

But fetch it as:

return NanPersistentToLocal(handle).As<v8::Function>();

But it should be, (as in Call()):

v8::Local<v8::Function> callback = NanPersistentToLocal(handle)->Get(NanSymbol("callback")).As<v8::Function>(); 

My bad. I can't recall why I added GetFunction() in and if I'm using it anywhere. It doesn't seem to be required in node-canvas.

[rvagg]

fixed in current 0.2.0, try again.

[kkoopa]

Hm, was I supposed to change anything other than NAN? Still not working after updating to new version.The end result is still the same, test reports 'callback not fired'.

I've had a successful build with 0.11.4 when not using NAN.

https://github.com/kkoopa/node-snappy

[rvagg]

ok, try again with 0.2.0, it's the NanScope() in GetFunction(), moving the Local to a new scope lost the reference.

[rvagg]

ooops, push didn't work, done now, working in your node-snappy.

[kkoopa]

Works in 0.11, not in 0.10. But more tests do pass with 0.10 than previously.

[kkoopa]

Never mind, removed a superfluous NanScope I had put locally in Init in binding.cc and now it seems to work. Upstream should pull it soon.
kesla/node-snappy#20