Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

upstream objection to -m #295

Closed
MylesBorins opened this issue Mar 18, 2019 · 1 comment
Closed

upstream objection to -m #295

MylesBorins opened this issue Mar 18, 2019 · 1 comment
Milestone
Upstream

Comments

@MylesBorins
Copy link
Contributor

see nodejs/ecmascript-modules#64 (comment)

I've removed it in nodejs/node@a3510b1, anyone have concerns with this?
@MylesBorins MylesBorins added the modules-agenda To be discussed in a meeting label Mar 18, 2019
@MylesBorins MylesBorins mentioned this issue Mar 18, 2019
Closed
@MylesBorins
Copy link
Contributor Author

in being hasty to get things in order I ended up rebasing this fix into the upstream PR (and module-lkgr).

I've archived this change, so that we can easily revert it, in https://github.com/MylesBorins/node/pull/new/remove-m

@MylesBorins MylesBorins added this to the Upstream milestone Mar 19, 2019
@SMotaal SMotaal mentioned this issue Mar 19, 2019
Closed
@MylesBorins MylesBorins mentioned this issue Mar 27, 2019
Closed
@GeoffreyBooth GeoffreyBooth removed modules-agenda To be discussed in a meeting labels May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Upstream
Development

No branches or pull requests
2 participants
@GeoffreyBooth @MylesBorins