Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turbofan support #126

Closed
brendangregg opened this issue Aug 25, 2017 · 3 comments
Closed

turbofan support #126

brendangregg opened this issue Aug 25, 2017 · 3 comments

Comments

@brendangregg
Copy link
Contributor

Does anything break with the new v8 turbofan compiler? Does llnode need changes to support it? I don't know myself, but am filing a ticket as a reminder that we need to check.

@joyeecheung
Copy link
Member

Related and fixed: #117

After using this patch (with a patched version of Node.js since https://chromium-review.googlesource.com/c/618986 has not landed in upstream yet), I have still been seeing evaluation failures when analyzing coredumps generated by Node.js v8.4.0. Will get to it later when I have a bit more time.

@cjihrig
Copy link
Contributor

cjihrig commented Sep 2, 2017

@joyeecheung see #130. I'm pretty close to having the test suite pass on V8 6.1.

EDIT: If you want to help with the last item, I'd gladly accept it :-)

@joyeecheung
Copy link
Member

@cjihrig Interesting, have not tried 6.1 yet. I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants