-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.0.7 release is broken for cmake users: #166
Comments
@mcollina please could you provide a similar llhttp-release-v6.0.7.[zip,tgz] for cmake users that also has (I'm guessing this is somehow automatically generated, since I can't see it in the github repo.) Thank you for maintaining llhttp! |
Where did you download that bundle file? |
https://github.com/nodejs/llhttp/releases the llhttp-release-v6.0.6 is available there for cmake (c-language) users llhttp is included with https://github.com/FDH2/UxPlay which I maintain. It is attributed as
I would upgrade the included llhttp to 6.0.7 if llhttp.c is available, but I have no problems with 6.0.6 |
I'm not sure what the difference between 2.1.5 and 6.0.7 is, but it seems you have accidentally released the wrong code as 6.0.7, I'm not sure how llhttp.c is produced, but I'm guessing it's produced by some automated algorithm from Node.js source? The correct size of release/v6.0.7 should be about 40kB not 6MB. EDIT: AHA! you accidentally released 6.0.7 from the "main" branch, not the "release" branch! I can now get what I need from github, but you should update the release to be from the correct branch. Thanks for your work!! |
Fixed, thanks! |
CMake Error at CMakeLists.txt:81 (add_library):
Cannot find source file:
we need a release like llhttp-6.0.6
The text was updated successfully, but these errors were encountered: