Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.0.7 release is broken for cmake users: #166

Closed
fduncanh opened this issue Jul 22, 2022 · 5 comments
Closed

v6.0.7 release is broken for cmake users: #166

fduncanh opened this issue Jul 22, 2022 · 5 comments

Comments

@fduncanh
Copy link
Contributor

CMake Error at CMakeLists.txt:81 (add_library):
Cannot find source file:

llhttp-6.0.7/src/llhttp.c

we need a release like llhttp-6.0.6

unzip llhttp-release-v6.0.6.zip
Archive:  llhttp-release-v6.0.6.zip
4bfeb625ce4961bd539c95593529936503be7db4
   creating: llhttp-release-v6.0.6/
  inflating: llhttp-release-v6.0.6/CMakeLists.txt  
  inflating: llhttp-release-v6.0.6/LICENSE-MIT  
  inflating: llhttp-release-v6.0.6/README.md  
  inflating: llhttp-release-v6.0.6/common.gypi  
   creating: llhttp-release-v6.0.6/include/
  inflating: llhttp-release-v6.0.6/include/llhttp.h  
  inflating: llhttp-release-v6.0.6/llhttp.gyp  
   creating: llhttp-release-v6.0.6/src/
  inflating: llhttp-release-v6.0.6/src/api.c  
  inflating: llhttp-release-v6.0.6/src/http.c  
  inflating: llhttp-release-v6.0.6/src/llhttp.c          <--------------------------missing in 6.0.7!!
@fduncanh
Copy link
Contributor Author

@mcollina
I think you also released v6.0.6

please could you provide a similar llhttp-release-v6.0.7.[zip,tgz] for cmake users that also has
llhttp.c in src/

(I'm guessing this is somehow automatically generated, since I can't see it in the github repo.)

Thank you for maintaining llhttp!

@mcollina
Copy link
Member

Where did you download that bundle file?

@fduncanh
Copy link
Contributor Author

fduncanh commented Jul 23, 2022

https://github.com/nodejs/llhttp/releases

the llhttp-release-v6.0.6 is available there for cmake (c-language) users
(I think you released it)

llhttp is included with https://github.com/FDH2/UxPlay which I maintain.

It is attributed as

Independent of UxPlay, but used by it and bundled with it:

    Fedor Indutny (of Node.js, and formerly Joyent, Inc) and contributors: 
Created an http parsing library called [llhttp](https://github.com/nodejs/llhttp). 
Located at lib/llhttp/. License: MIT

I would upgrade the included llhttp to 6.0.7 if llhttp.c is available, but I have no problems with 6.0.6

@fduncanh
Copy link
Contributor Author

fduncanh commented Jul 23, 2022

@mcollina

I'm not sure what the difference between 2.1.5 and 6.0.7 is, but it seems you have accidentally released the wrong code as 6.0.7,
which seems to be just 2.1.5 with CmakeLists.txt added , not the correct "release" code, as in the v6.0.x series.

I'm not sure how llhttp.c is produced, but I'm guessing it's produced by some automated algorithm from Node.js source?
I can't see it in the repo.

see
v6.0.7...release/v6.0.6

The correct size of release/v6.0.7 should be about 40kB not 6MB.

EDIT: AHA! you accidentally released 6.0.7 from the "main" branch, not the "release" branch!

I can now get what I need from github, but you should update the release to be from the correct branch. Thanks for your work!!

@mcollina
Copy link
Member

Fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants