Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

FAQ link is absolute and should be relative #267

Closed
yoannmoinet opened this issue Mar 4, 2015 · 6 comments · Fixed by #268
Closed

FAQ link is absolute and should be relative #267

yoannmoinet opened this issue Mar 4, 2015 · 6 comments · Fixed by #268

Comments

@yoannmoinet
Copy link
Contributor

The link to faq.html is absolute instead of being relative.
It seems to be the case in all languages.

So everyone is redirecting to the english version of the faq.

@AntouanK
Copy link
Contributor

AntouanK commented Mar 4, 2015

Is every team going to make a PR for that link to be fixed?
Or is someone going to fix all of them?
( I don't know which languages are inactive, so I don't know if I should make a PR with all of the index.md files fixed... )

@yoannmoinet
Copy link
Contributor Author

I'm currently preparing a PR for every page.
That's quite easy... just a bulk search & replace.

@AntouanK
Copy link
Contributor

AntouanK commented Mar 4, 2015

But some languages are inactive I think.
Well, I guess there's no harm in fixing them, they'll have the english content anyway.

@snostorm
Copy link
Contributor

snostorm commented Mar 4, 2015

@AntouanK the excess English articles should be removed (as of a merge earlier today). Anyway, regardless, ya, the individual ./content files need to be updated to fix this otherwise any manual changes to public will get stomped.

Feel free to mass-fix the source .md (that's the actual fix needed.)

@AntouanK
Copy link
Contributor

AntouanK commented Mar 4, 2015

@yoannmoinet, you're preparing the PR, right?
I see it's done #268

@snostorm
Copy link
Contributor

snostorm commented Mar 4, 2015

@AntouanK #268 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants