-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add note about available ECC curves #1913
Conversation
Added instructions on how to get the elliptic curves supported by the OpenSSL installation in the crypto.createECDH() constructor. Also made a few minor grammar fixes within the same paragraph.
Could you also add this to the |
Sure, I'll go do that right now |
Maybe we should have a function that returns the supported curve names like we have with ciphers and hashes? |
@silverwind I just extended the note about getting available curves to the TLS docs as well. |
Let's remove the RFC note above (it's not really helpful at first glance) and then put your message on the same line. |
Ok, done |
LGTM |
FWIW we can use |
Wow, that is pretty neat indeed. |
Going to merge this now, we can update docs again in the other PR. |
predefined curve specified by `curve_name` string. | ||
Creates an Elliptic Curve (EC) Diffie-Hellman key exchange object using a | ||
predefined curve specified by the `curve_name` string. On recent releases, | ||
`openssl ecparam -list_curves` will display the name and description of each |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petschekr trailing whitespace on this line, could you remove that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silverwind Just fixed it in b116c6f
Added instructions on how to get the elliptic curves supported by the OpenSSL installation in the crypto.createECDH() constructor. Also made a few minor grammar fixes within the same paragraph. PR-URL: #1913 Reviewed-By: Roman Reiss <me@silverwind.io>
Thanks! landed in deb8b87 |
Added instructions on how to get the elliptic curves supported by the OpenSSL installation in the
crypto.createECDH()
constructor. Also made a few minor grammar fixes within the same paragraph.