Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add note about available ECC curves #1913

Closed
wants to merge 4 commits into from

Conversation

petschekr
Copy link
Contributor

Added instructions on how to get the elliptic curves supported by the OpenSSL installation in the crypto.createECDH() constructor. Also made a few minor grammar fixes within the same paragraph.

Added instructions on how to get the elliptic curves supported by the
OpenSSL installation in the crypto.createECDH() constructor. Also made
a few minor grammar fixes within the same paragraph.
@silverwind
Copy link
Contributor

Could you also add this to the ecdhCurve option of tls.createServer? If that RFC link is still relevant, keep it, otherwise remove it I'd say.

@mscdex mscdex added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Jun 7, 2015
@petschekr
Copy link
Contributor Author

Sure, I'll go do that right now

@mscdex
Copy link
Contributor

mscdex commented Jun 7, 2015

Maybe we should have a function that returns the supported curve names like we have with ciphers and hashes?

@petschekr
Copy link
Contributor Author

@silverwind I just extended the note about getting available curves to the TLS docs as well.

@silverwind
Copy link
Contributor

Let's remove the RFC note above (it's not really helpful at first glance) and then put your message on the same line.

@petschekr
Copy link
Contributor Author

Ok, done

@silverwind
Copy link
Contributor

LGTM

@mscdex
Copy link
Contributor

mscdex commented Jun 7, 2015

FWIW we can use crypto.getCurves() to get available curves if #1914 gets accepted.

@silverwind
Copy link
Contributor

Wow, that is pretty neat indeed.

@silverwind
Copy link
Contributor

Going to merge this now, we can update docs again in the other PR.

predefined curve specified by `curve_name` string.
Creates an Elliptic Curve (EC) Diffie-Hellman key exchange object using a
predefined curve specified by the `curve_name` string. On recent releases,
`openssl ecparam -list_curves` will display the name and description of each
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petschekr trailing whitespace on this line, could you remove that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silverwind Just fixed it in b116c6f

silverwind pushed a commit that referenced this pull request Jun 7, 2015
Added instructions on how to get the elliptic curves supported by the
OpenSSL installation in the crypto.createECDH() constructor. Also made
a few minor grammar fixes within the same paragraph.

PR-URL: #1913
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind
Copy link
Contributor

Thanks! landed in deb8b87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants