fs: set encoding on fs.createWriteStream #1844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please re-review for document and test. |
| const secondEncoding = 'binary'; | ||
|
|
||
| const examplePath = path.join(common.fixturesDir, 'x.txt'); | ||
| const dummyPath = path.join(common.tmpDir, '/x.txt'); |
There was a problem hiding this comment.
There is an extra / in the second argument to path.join().
|
Thank you. Fixed. |
|
I will land this when CI is healthy. |
yosuke-furukawa
added a commit
that referenced
this pull request
Jun 2, 2015
Enable encoding option on fs.createWriteStream. PR-URL: #1844 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
landed 8357c50 |
andrewdeandrade
pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
Enable encoding option on fs.createWriteStream. PR-URL: nodejs/node#1844 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just separated #1412 .
Much time passed since I proposed the pull request. Sorry.
I would like to introduce the pull request again.
According to the createWriteStream api docs,
encodingoption could be found.But I set the encoding option to fs.createWriteStream('foo.txt', {encoding: 'utf8'}), the encoding option is ignored. I fixed the problem.
And I added the
encodingdescription in this doc. and I fixed test to avoid linter error.