Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic test-coverage threshold #4483

Open
nicholaswmin opened this issue Sep 15, 2024 · 1 comment
Open

Generic test-coverage threshold #4483

nicholaswmin opened this issue Sep 15, 2024 · 1 comment

Comments

@nicholaswmin
Copy link

nicholaswmin commented Sep 15, 2024

@redyetidev The experimental coverage thresholds came out super nice.

What do you think about this?

node --test-coverage=90

... which applies equal threshold 90 to line, branch, function or is that too much fluff?

The idea is to avoid long scripts node --and-this --and-that ...x

Minimal Reproduction

n/a

Output

n/a

@avivkeller
Copy link
Member

avivkeller commented Sep 15, 2024

IIRC we discussed that, but ultimately decided to wait until coverage thresholds have matured a bit before aliasing them.

I'm +1 on it, but IMO it should wait a bit, to see how coverage thresholds grow, and be done before marking coverage as stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants