Extensibility

[williamkapke]

The path I was going was to use @rvagg's github-webhook-handler which sets things up in an evented way: when hook data comes in, emit the event. I took it a step further to emit event+'.'+action for more granularity.

I created a scripts directory where scripts could be added and they can listen to whatever events they need.

Here is echo.js that I created as an example:

var github = require('../github.js');

module.exports = function (org) {

  org.on('issue_comment.created', event=>{
    //this would be circular if we don't ignore ourself!
    if(!event.sender || !github.me || event.sender.id===github.me.id) return;

    var repo = event.repository;
    github.issues.createComment({
      user: repo.owner.login,
      repo: repo.name,
      number: event.issue.number,
      body: event.comment.body
    })
  });

};

How do you feel about going this route? It looks like the work in pollTravis could be done with this approach.

But, that was just my approach... ;) What way(s) do you see extending this to include other scripts/workers?

[phillipj]

An evented approach sounds excellent 👍 I didn't want to over engineer this right at the get go, that's why there's not much extensibility in it yet.

Would you be able to open a PR with some changes going in the direction you're describing?

[williamkapke]

Sure thing. I'll try to work on it tonight.

I see /pr/:owner/:repo/:prId... that looks interesting- were you experiencing problems that needed this to be manually kicked off? Maybe this was for testing..?

Testing is a really tough part here. I setup an org and a bot account for testing. If anyone else is testing and wants me to add another webhook endpoint, LMK.
^{Don't subscribe to notifications there! Things get chatty.}

[phillipj]

Maybe this was for testing..?

Yupp. Having an endpoint to request for existing PR's was useful at the beginning. It has been overly well behaved since though, so that endpoint hasn't been of much use.

Testing is a really tough part here. I setup an org and a bot account for testing. If anyone else is testing and wants me to add another webhook endpoint, LMK.

Know the feeling. Seems like the procedure you're about to put into place is pretty complex :) We should absolutely invest some time in automated tests after we get this skeleton up and running, as manually testing each of these procedures when merging changes sounds like a nightmare.

[Fishrock123]

maybe we should investigate how the nodeschool bot works?

[williamkapke]

@Fishrock123 I looked into their impl and it is a roll-your-own setup. Everything in 1 file.

[williamkapke]

Closed by #8