Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release_urlbase as an option in iojs+release #393

Closed
MylesBorins opened this issue Apr 20, 2016 · 5 comments
Closed

Remove release_urlbase as an option in iojs+release #393

MylesBorins opened this issue Apr 20, 2016 · 5 comments

Comments

@MylesBorins
Copy link
Contributor

It is my impression that the release_urlbase is deterministic. That is to say that whatever disttype you select will ultimately decide which release_urlbase the build will expect to find the headers.

I would like propose removing this option from CI and inferring the url from the selected disttype. This will get rid of the nasty case where we forget to set it correctly.

@MylesBorins
Copy link
Contributor Author

/cc @jbergstroem

@jbergstroem
Copy link
Member

I'd prefer if @rvagg chipped in here seeing how I haven't done much work in this area.

@rvagg
Copy link
Member

rvagg commented Jun 7, 2016

I can't think of a good reason not to collapse it now. It was put there because at the time I was attempting to keep as much logic out of the Jenkins scripts as possible so we don't build up too much reliance on this beast, but that day has well passed now. Originally IIRC this was freeform text so it could point to anywhere. We've narrowed down the use of it a lot more now. Even the custom -> rc thing could be scripted away, the custom was a compromise I had to make when getting approval from others to land the code in Makefile that controls this.

@MylesBorins
Copy link
Contributor Author

@nodejs/build can we move forward on this?

@MylesBorins
Copy link
Contributor Author

This has happened and I am happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants