-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove release_urlbase as an option in iojs+release #393
Comments
/cc @jbergstroem |
I'd prefer if @rvagg chipped in here seeing how I haven't done much work in this area. |
I can't think of a good reason not to collapse it now. It was put there because at the time I was attempting to keep as much logic out of the Jenkins scripts as possible so we don't build up too much reliance on this beast, but that day has well passed now. Originally IIRC this was freeform text so it could point to anywhere. We've narrowed down the use of it a lot more now. Even the |
@nodejs/build can we move forward on this? |
This has happened and I am happy |
It is my impression that the
release_urlbase
is deterministic. That is to say that whateverdisttype
you select will ultimately decide whichrelease_urlbase
the build will expect to find the headers.I would like propose removing this option from CI and inferring the url from the selected disttype. This will get rid of the nasty case where we forget to set it correctly.
The text was updated successfully, but these errors were encountered: