Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 tests need svn installed #306

Closed
mhdawson opened this issue Jan 15, 2016 · 4 comments
Closed

V8 tests need svn installed #306

mhdawson opened this issue Jan 15, 2016 · 4 comments

Comments

@mhdawson
Copy link
Member

Early work to enable V8 testing from the Node tree for #199 shows that we need svn installed on the test machines

https://ci.nodejs.org/job/mdawson-RunV8TestsInNode/8/console

I checked on the machines where I had run the tests before and our internal machines were we (IBM) build v8 regularly and see that we do have svn installed.

Any objects to installing svn on the test machines. If not I can go ahead and add it to the ansible templates. Having done that do we need to re-image or would we just install by hand ?

@rvagg
Copy link
Member

rvagg commented Jan 15, 2016

such pain ... we had to use svn in our internal CI system a while back and it was so painful that we ended up working around it completely. iirc Windows was the worst.

@jbergstroem
Copy link
Member

Do we want to run v8 on all our test machines or a limited subset?

@mhdawson
Copy link
Member Author

Unless there is a reason to avoid svn I'd think it would just be easier to enable on all machines as opposed to limiting to a subset.

@mhdawson
Copy link
Member Author

PR here to start adding #330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants