Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New repos for sample ci configs #477

Closed
mhdawson opened this issue Mar 10, 2020 · 14 comments
Closed

New repos for sample ci configs #477

mhdawson opened this issue Mar 10, 2020 · 14 comments

Comments

@mhdawson
Copy link
Member

The package maintenance team would like 2 new repos to maintain sample CI configs for using Travis and Github actions.

See: nodejs/package-maintenance#321

The team has made recommendations in terms of what Node.js versions to test on, and would like to provide ci configs which support those recommendations.

The repos we'd like are:

  • nodejs/ci-config-travis
  • nodejs/ci-config-github-actions
@mhdawson
Copy link
Member Author

The discussion ended up with using a separate repo for each type of ci so that

  • we could have different teams maintaining the repos
  • some ci's only seem to allow an org/repo reference as opposed to a path within the repo.

@mhdawson
Copy link
Member Author

@nodejs/tsc would be good to get some approvals on this.

@mhdawson
Copy link
Member Author

@nodejs/community-committee ping as well.

@richardlau
Copy link
Member

@nodejs/tsc would be good to get some approvals on this.

It might be nice but technically you don't need any approvals -- just no objections in a 72 hour period: https://github.com/nodejs/admin/blob/master/GITHUB_ORG_MANAGEMENT_POLICY.md#repositories

@mcollina
Copy link
Member

+1

@mhdawson
Copy link
Member Author

@richardlau I understand that, but would like a few +1's anyway.

@mmarchini
Copy link
Contributor

+1

@nschonni
Copy link
Member

Wouldn't it be better to just work with their docuementation teams to improve their official docs like https://github.com/travis-ci/docs-travis-ci-com/edit/master/user/languages/javascript-with-nodejs.md

@dominykas
Copy link
Member

We've tried reaching out to see if the defaults can be changed, and we did get some traction in the right direction, but this is broader than just that, e.g. we want shareable and automatically updatad configs to run tests in all LTS versions since 8, or all versions that ever existed - depending on your support policy.

We also want to lower the burden on maintainers to not have to keep that up to date, esp. if they have a lot of repos.

I also think that the node community would probably be better in deciding and maintaining and advocating the options available, letting CI providers focus on what they do best.

@mhdawson
Copy link
Member Author

Tagged for agenda as FYI, if no objections after meeting time will consider approved and move to create.

@bnb
Copy link
Contributor

bnb commented Mar 31, 2020

Huge +1. I am also happy to help maintain GitHub Actions CI templates since I’ve been working with them quite a bit lately ❤️

@mhdawson
Copy link
Member Author

mhdawson commented Apr 6, 2020

Should have taken this off the agenda as FYI complete

@mhdawson
Copy link
Member Author

The repos have been created, closing. The maintainers will be managed through the ci-config-travis-maintainers and ci-config-github-actions-maintainers teams. Initially I've just added @dominykas to that list. We have an action to document more governance for the package maintenance team and we'll include in that how the two maintainer teams will be managed.

@ljharb
Copy link
Member

ljharb commented Apr 14, 2020

I’d like to be on the Travis list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants