Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate org invitation of new contributors in nodejs/nodejs.org #266

Closed
fhemberger opened this issue Nov 6, 2018 · 16 comments
Closed

Automate org invitation of new contributors in nodejs/nodejs.org #266

fhemberger opened this issue Nov 6, 2018 · 16 comments

Comments

@fhemberger
Copy link

The nodejs/nodejs.org repo regularly adds new contributors as new team members. This allowed us to assemble a great, very committed team of 165 members, handling every aspect of the website including translations for thirteen languages.

So far, this has been a manual task, performed every couple of months. As a team maintainer, I can add existing Node.js org members to the website team, but it requires an org admin to onboard new members. So instead of setting up a regular reminder for myself to compile the list of new contributors and then needing to bother an admin to invite each of them manually, there's a GitHub bot that could automate the process:

https://probot.github.io/apps/invite-contributors (source)

I would require the following permissions:
image

Is there any way we could set it up for the website repo?

Ref: nodejs/nodejs.org#1872

@fhemberger
Copy link
Author

/ping @bnb @mhdawson @MylesBorins

@MylesBorins
Copy link
Contributor

@fhemberger I am not personally comfortable with giving a bot administration privileges. I'll not block on this if others sign off though.

@bnb
Copy link
Contributor

bnb commented Nov 12, 2018

I am fine with this. As far as I know all sensitive data (in a Security sense) has been moved out of this organization.

IMO we need to begin allowing org members to smooth out their workflow with bots. I've asked various people at least a dozen times and have been told to go somewhere else to ask, never actually getting an answer.

This bot will reduce the maintenance burden on the current active contributors (mainly @fhemberger), which we should not be stopping because we don't have a process defined and nobody is willing/able to define a process.

@refack
Copy link
Contributor

refack commented Nov 12, 2018

We should also consider that org members get two extra privileges: access to nodejs/moderation, and free individual membership in the foundation.

I know it's a bit cumbersome, but I prefer that this decision will be done by a human.

@fhemberger
Copy link
Author

I know it's a bit cumbersome, but I prefer that this decision will be done by a human.

Well, as I've been the only human caring about the onboarding since I took over from Mikeal, I don't want to do this job manually any longer:

  1. Setup a reminder
  2. Run the script, compiling the list (approx. 10-20 new contributors on each run)
  3. Create an issue
  4. Having to bother an admin to send out the invitations
  5. Rinse and repeat every 2-3 months.

There has to be a way to improve the situation and I'd love your help with that.

@refack
Copy link
Contributor

refack commented Nov 12, 2018

There has to be a way to improve the situation and I'd love your help with that.

Ack.

@bnb
Copy link
Contributor

bnb commented Nov 26, 2018

We should also consider that org members get two extra privileges: access to nodejs/moderation, and free individual membership in the foundation.

These aren't excessively useful benefits, especially since the people are literally contributing and these are benefits given to contributors. Since the Website WG has its own governance, it can add people as contributors however it wants.

As a former or current (I really have zero clue at this point) Website WG member, I've seen @fhemberger working on this for years now and would +1 his suggestions on this in any case because he's been the one doing the work.

@ghost
Copy link

ghost commented Feb 4, 2019

Not sure whether this auto bot starts or not, but now there're some contributors, and maybe they should be the Member of Nodejs.org before becoming the member of the specific language group, so if the auto bot isn't ready yet, would anyone can invite them into Nodejs.org?

@nodejs/nodejs-it:
@xela92 @aymen94

@nodejs/nodejs-ar:
@celyes

@MylesBorins
Copy link
Contributor

@Maledong do you have reference to where they have made contributions or requested membership?

@fhemberger
Copy link
Author

@Maledong Sorry, the idea with the bot has been postponed (see #282 (comment)), so I stopped adding new members at the moment.

Maybe we can add them as external collaborators to the language specific groups in the mean time. It doesn't give them commit rights to the website repo for now, but at least they can be @-mentioned when addressing the group.

@fhemberger
Copy link
Author

For translations, I'd like to switch to Crowdin (as it is already used for the docs). I think the whole @nodejs/nodejs-* group thing could possibly be managed in a different way as well.

Ref: nodejs/i18n#72

@ghost
Copy link

ghost commented Feb 4, 2019

@MylesBorins:
Here're the detail info of their contributions:

@celyesnodejs/nodejs.org#2030
@aymen94nodejs/nodejs.org#2024
@xela92nodejs/nodejs.org#1762 (A huge pending submit).

@fhemberger
Copy link
Author

I agree to add these three to the website group, also @Yash-Handa for his amazing work of going through all the old Nodejitsu knowledge base articles and updating them.

@MylesBorins Could you please add them?

(also I'm closing this issue, as we won't have an automated process for this.)

@MylesBorins
Copy link
Contributor

I've added all 3 to the website group.

@fhemberger
Copy link
Author

Thanks!

@Yash-Handa
Copy link

Thanks, @MylesBorins for adding us to the family ❤️

Btw, there were 4 of us, I think you forget me (@Yash-Handa) 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants