Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track backporting Path optimizations #87

Closed
MylesBorins opened this issue Mar 11, 2016 · 3 comments
Closed

Track backporting Path optimizations #87

MylesBorins opened this issue Mar 11, 2016 · 3 comments

Comments

@MylesBorins
Copy link
Contributor

Original PR:

Fixes:

The number of regressions already found makes me a bit anxious about landing these changes. Personally I would like to see this live on v5.x for as long as possible before we backport to v4.x, if we do at all.

A good sign that it is time to backport this will be when we are having trouble landing other unrelated fixes / changes. Until that happens I think it would make the most sense to hold off and keep this issue updated.

I've added the lts-agenda tag so that we can discuss this at the next meeting

@MylesBorins
Copy link
Contributor Author

I think this one should go with it too nodejs/node@9de9a08 from nodejs/node#5673

@MylesBorins
Copy link
Contributor Author

Looks like we'll also need nodejs/node@3072546 from nodejs/node#6028

@MylesBorins
Copy link
Contributor Author

Closing for now. This will be reopened if we find that the path changes need to land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant