Semver Minor Tracking

[MylesBorins]

We have a month with 5 Tuesdays, this means we can do a Semver Minor release!!!

I'm thinking it makes sense for both 6.x and 8.x.

Will follow up with a list of potential commits soon (unless someone else wants to do it first :D)

[MylesBorins]

@nodejs/lts quick ping, do people have time to meet and discuss this at all next week?

[gibfahn]

Next week SGTM

[mhdawson]

Next week SGTM

[MylesBorins]

I've created two gists
node v6.x semver minors
node v8.x semver minors

I'm quite sick and may not have the ability to review this in a timely fashion

@nodejs/release @nodejs/lts @nodejs/collaborators @nodejs/tsc would people be able to review these lists and please request the semver minor commits you would like to see on the next LTS release on v6.x and v8.x

[TimothyGu]

Let me know what I need to do to get nodejs/node#17365 into v6.x, or if it is already ready to be applied.

[mcollina]

I would like to have:

nodejs/node@c5c4a534d1
nodejs/node@4b0c8759d3
nodejs/node@edb9846884

backported.

_{(edited by @addaleax: made commits clickable)}

[MylesBorins]

Another quick ping to @nodejs/collaborators to review these lists. I really would appreciate any work y'all can do.

[evanlucas]

I would like to see nodejs/node@8d90db5120 and the async_hooks commits land in v8.x

[AndreasMadsen]

@evanlucas Indeed, I tried adding lts-watch-v8.x to all the async_hooks changes.

[MylesBorins]

@AndreasMadsen would you be able to do a batch backport?

[AndreasMadsen]

@MylesBorins I can definitely try.

[MylesBorins]

@AndreasMadsen for async_hooks were you talking about 8.x or 6.x?

[MylesBorins]

@mcollina here is a list of streams based commits to review (will be updated)

• stream: add final method node#12828 needs backport
• stream: support Uint8Array input to methods node#11608 needs backport
• stream: support readable/writableHighWaterMark for Duplex streams node#14636 lands cleanly
• net: return this from destroy() node#13530

[MylesBorins]

We would like to land nodejs/node#13467 but it requires manual backport of the documentation. Would someone be interested in taking that on?

[MylesBorins]

@Trott would you want to backport nodejs/node#14910 to v6.x? nbd if you don't have time

[MylesBorins]

@cjihrig would you want to backport nodejs/node#15034 to v6.x?

[MylesBorins]

@nodejs/crypto would anyone want to backport nodejs/node#15206?

[MylesBorins]

@danbev could you backport nodejs/node#16790

[gibfahn]

@maclover7 could you backport nodejs/node#16386 ?

[AndreasMadsen]

async_hooks should not land in 6.x. I have already added dont-land labels for 6.x

[AndreasMadsen]

I think this is the list of async_hooks commits there should be backported. Some of these are trace_events related, but async_hooks and trace_events becomes connected as we are now emitting async_hooks event through trace_events. I would be nice to backport the trace_events changes anyway. I will try and make a batch backport, although I might need help with nodejs/node#16565.

• [b12425d055] - async_hooks,test: only use IPv6 in http test (Andreas Madsen) async_hooks,test: Only use IPv6 in http test node#18143
• [8479606a24] - (SEMVER-MINOR) async_hooks,http: set HTTPParser trigger to socket (Andreas Madsen) async_hooks,http: set HTTPParser trigger to socket node#18003
• [fbad8bb1fa] - async_hooks: update defaultTriggerAsyncIdScope for perf (Anatoli Papirovski) async_hooks: update defaultTriggerAsyncIdScope for perf node#18004
• [6aac05bf47] - trace_events: stop tracing agent in process.exit() (Andreas Madsen) trace_events: stop tracing agent in process.exit() node#18005
• [83e5215a4e] - async_hooks: use typed array stack as fast path (Anna Henningsen) async_hooks: use typed array stack as fast path  node#17780
• [81c2b59609] - async_hooks: use CHECK instead of throwing error (Jon Moss) async_hooks: use CHECK instead of throwing error node#17832
• [3b8da4cbe8] - async_hooks: use scope for defaultTriggerAsyncId (Andreas Madsen) Refactor async_hooks initTriggerId node#17273
• [0784b0440c] - async_hooks: separate missing from default context (Andreas Madsen) Refactor async_hooks initTriggerId node#17273
• [f3f1a9349a] - async_hooks: rename initTriggerId (Andreas Madsen) Refactor async_hooks initTriggerId node#17273
• [ad80c21206] - (SEMVER-MINOR) trace_events: add executionAsyncId to init events (Andreas Madsen) trace_events: add executionAsyncId to init events node#17196
• [5d7f5c16b3] - src: remove async_hooks destroy timer handle (Anna Henningsen) src: introduce internal C++ SetImmediate() and remove async_hooks destroy timer node#17117
• [07a4fa3dbe] - (SEMVER-MINOR) async_hooks: deprecate undocumented API (Andreas Madsen) async_hooks: deprecate undocumented API node#16972
• [d6ac8a4db0] - src: use NODE_BUILTIN_MODULE_CONTEXT_AWARE() macro (Ben Noordhuis) src: use NODE_BUILTIN_MODULE_CONTEXT_AWARE() macro node#17071
• [22901d81c9] - (SEMVER-MINOR) async_hooks: add destroy event for gced AsyncResources (Sebastian Mayr) async_hooks: Add destroy event for gced AsyncResources node#16998
• [d217b2850e] - (SEMVER-MINOR) async_hooks: add trace events to async_hooks (Andreas Madsen) async-hooks: add trace events to AsyncWrap node#15538
• [787863ddb4] - src: use unique pointer for tracing_agent (Franziska Hinkelmann) src: use unique pointer for tracing_agent node#17012
• [8680bb9f1a] - src: explicitly register built-in modules (Yihong Wang) src: explicitly register built-in modules node#16565

[gibfahn]

although I might need help with nodejs/node#16565.

If it'd make more sense for @yhwang to backport that one separately that's fine by me.

[AndreasMadsen]

@gibfahn It wasn't too big of an issue. I have already backported the first 7 commits.

I hope to have it all done within the next 6 hours. I would appreciate if we can put v8.x-staging on hold until then, so I don't have to do all this again.

[AndreasMadsen]

I was missing two commits there was under the async_wrap tag.

• [b12425d055] - async_hooks,test: only use IPv6 in http test (Andreas Madsen) async_hooks,test: Only use IPv6 in http test node#18143
• [8479606a24] - (SEMVER-MINOR) async_hooks,http: set HTTPParser trigger to socket (Andreas Madsen) async_hooks,http: set HTTPParser trigger to socket node#18003
• [fbad8bb1fa] - async_hooks: update defaultTriggerAsyncIdScope for perf (Anatoli Papirovski) async_hooks: update defaultTriggerAsyncIdScope for perf node#18004
• [6aac05bf47] - trace_events: stop tracing agent in process.exit() (Andreas Madsen) trace_events: stop tracing agent in process.exit() node#18005
• [83e5215a4e] - async_hooks: use typed array stack as fast path (Anna Henningsen) async_hooks: use typed array stack as fast path  node#17780
• [81c2b59609] - async_hooks: use CHECK instead of throwing error (Jon Moss) async_hooks: use CHECK instead of throwing error node#17832
• [3b8da4cbe8] - async_hooks: use scope for defaultTriggerAsyncId (Andreas Madsen) Refactor async_hooks initTriggerId node#17273
• [0784b0440c] - async_hooks: separate missing from default context (Andreas Madsen) Refactor async_hooks initTriggerId node#17273
• [f3f1a9349a] - async_hooks: rename initTriggerId (Andreas Madsen) Refactor async_hooks initTriggerId node#17273
• [b44efded84] - (SEMVER-MINOR) async_wrap: add provider types for net server (Andreas Madsen) async_wrap: add provider types for net server node#17157
• [ad80c21206] - (SEMVER-MINOR) trace_events: add executionAsyncId to init events (Andreas Madsen) trace_events: add executionAsyncId to init events node#17196
• [5d7f5c16b3] - src: remove async_hooks destroy timer handle (Anna Henningsen) src: introduce internal C++ SetImmediate() and remove async_hooks destroy timer node#17117
• [07a4fa3dbe] - (SEMVER-MINOR) async_hooks: deprecate undocumented API (Andreas Madsen) async_hooks: deprecate undocumented API node#16972
• [78447666ea] - src: rename async-wrap -> async_wrap (Daniel Bevenius) src: rename async-wrap -> async_wrap node#17022
• [d6ac8a4db0] - src: use NODE_BUILTIN_MODULE_CONTEXT_AWARE() macro (Ben Noordhuis) src: use NODE_BUILTIN_MODULE_CONTEXT_AWARE() macro node#17071
• [22901d81c9] - (SEMVER-MINOR) async_hooks: add destroy event for gced AsyncResources (Sebastian Mayr) async_hooks: Add destroy event for gced AsyncResources node#16998
• [d217b2850e] - (SEMVER-MINOR) async_hooks: add trace events to async_hooks (Andreas Madsen) async-hooks: add trace events to AsyncWrap node#15538
• [787863ddb4] - src: use unique pointer for tracing_agent (Franziska Hinkelmann) src: use unique pointer for tracing_agent node#17012
• [8680bb9f1a] - src: explicitly register built-in modules (Yihong Wang) src: explicitly register built-in modules node#16565

[AndreasMadsen]

@MylesBorins @gibfahn @evanlucas I have finished the async_hooks backport, the list became quite long: nodejs/node#18179 Please merge this as fast as possible, I don't want to do it again because some commit got merged into v8.x-staging.

[TimothyGu]

nodejs/node#17470 should also be included in the v6.x backport of WHATWG URL parser as it fixes a critical memory leak. It had not been landed yet at the time of my backport PR, and I neglected to add it in after it had by mistake.

[MylesBorins]

@TimothyGu lands cleanly on v8.x with green tests. Doesn't work on v6.x as nodejs/node@9236dfe utilizes std::move. Requesting backport