-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Unable to override default authnRequestBinding when using MultiSamlStrategy #528
Comments
Would you be willing to make a PR to address this @mhesler74 ? |
It's currently a "global" passport configuration passport-saml/test/multiSamlStrategy.js Line 136 in 43465d6
Do you need it, to be set per client? |
Yes, I need it set per client. Some of our customers are using HTTP-Request binding for authentication while others support HTTP-POST. |
Actually another PR was put in a while back by someone else... very similar |
Any ETA on when this will be included in a release? |
I believe this is part of the v3 release, which is held up due to some missing code reviews. See https://github.com/node-saml/passport-saml/milestone/1. |
passport.authenticate only uses the default authnRequestBinding setting when using the MultiSamlStrategy class.
Providing an alternative authnRequestBinding setting as a return value in the getSamlOptions function is completely ignored.
The text was updated successfully, but these errors were encountered: