Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check writeStream destroyed before send request #460

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Aug 17, 2023

Only check on Node.js < 18

closes #459

@fengmk2 fengmk2 added the bug Something isn't working label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #460 (c5bece8) into master (1d26bb8) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   99.63%   99.64%           
=======================================
  Files           8        8           
  Lines        1386     1394    +8     
  Branches      245      247    +2     
=======================================
+ Hits         1381     1389    +8     
  Misses          5        5           
Files Changed Coverage Δ
src/HttpAgent.ts 100.00% <100.00%> (ø)
src/HttpClient.ts 99.56% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fengmk2 fengmk2 merged commit 78515b9 into master Aug 17, 2023
@fengmk2 fengmk2 deleted the fix-writeStream-error branch August 17, 2023 14:02
fengmk2 pushed a commit that referenced this pull request Aug 17, 2023
[skip ci]

## [3.17.2](v3.17.1...v3.17.2) (2023-08-17)

### Bug Fixes

* check writeStream destroyed before send request ([#460](#460)) ([78515b9](78515b9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using version 3.x, if an error occurs in writeStream, no error will be thrown
1 participant