fix: don't listen response aborted on node > 0.10 #252
Conversation
see detail on 316da40
|
@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse, @xingrz and @ibigbug to be potential reviewers. |
lib/urllib.js
Outdated
| if (isOldVersionNode) { | ||
| waitEvents.push([res, 'aborted']); | ||
| } | ||
| first(waitEvents, function(_, stream, event) { |
There was a problem hiding this comment.
只在 0.10 依赖 aborted 事件，其他版本只依赖 close 事件
|
CI 挂了 |
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
- Coverage 97.38% 96.84% -0.55%
==========================================
Files 4 4
Lines 535 538 +3
Branches 132 133 +1
==========================================
Hits 521 521
- Misses 14 17 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
- Coverage 97.38% 96.66% -0.73%
==========================================
Files 4 4
Lines 535 539 +4
Branches 132 134 +2
==========================================
Hits 521 521
- Misses 14 18 +4
Continue to review full report at Codecov.
|
|
额，ci 还是没过 |
|
0.12 也得使用 res aborted |
|
LGTM |
|
2.21.2 |
see detail on 316da40