feat: support http(s) proxy #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @xingrz, @dead-horse and @coderhaoxin to be potential reviewers. |
Merged
fengmk2
force-pushed
the
support-http-proxy
branch
from
1a05460 to
b901cb7
Compare
fengmk2
changed the title
dead-horse
approved these changes
Mar 16, 2017
|
CI 挂了，jshint 没过 |
|
先不合，有bug
…Sent from my iPhone
On 16 Mar 2017, at 2:38 PM, Yiyu He ***@***.***> wrote:
CI 挂了，jshint 没过
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
fengmk2
force-pushed
the
support-http-proxy
branch
from
5eac62c to
12877f3
Compare
atian25
reviewed
Jul 28, 2017
lib/urllib.js
Outdated
| @@ -113,6 +114,8 @@ var PROTO_RE = /^https?:\/\//i; | |||
| * - {Boolean} [timing]: Enable timing or not, default is `false`. | |||
| * - {Function} [lookup]: Custom DNS lookup function, default is `dns.lookup`. | |||
| * Require node >= 4.0.0 and only work on `http` protocol. | |||
| * - {Boolean} [enableProxy]: optional, enable proxy request. Default is `false`. | |||
| * - {String|Object} [proxy]: optional proxy agent uri or options. Default is `null`. | |||
| * @param {Function} [callback], callback(error, data, res). If missing callback, will return a promise object. | |||
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
- Coverage 97.83% 92.59% -5.24%
==========================================
Files 4 6 +2
Lines 553 608 +55
Branches 139 161 +22
==========================================
+ Hits 541 563 +22
- Misses 12 45 +33
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
- Coverage 97.83% 93.24% -4.59%
==========================================
Files 4 6 +2
Lines 553 607 +54
Branches 139 161 +22
==========================================
+ Hits 541 566 +25
- Misses 12 41 +29
Continue to review full report at Codecov.
|
Closed
|
2.24.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes cnpm/npminstall#135