Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add -2 status for connect timeout #224

Merged
merged 1 commit into from
Oct 13, 2016
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Oct 13, 2016

closes #223

@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @xingrz, @dead-horse and @ibigbug to be potential reviewers.

@codecov-io
Copy link

codecov-io commented Oct 13, 2016

Current coverage is 98.03% (diff: 100%)

Merging #224 into master will increase coverage by <.01%

@@             master       #224   diff @@
==========================================
  Files             1          1          
  Lines           457        459     +2   
  Methods          40         40          
  Messages          0          0          
  Branches        119        120     +1   
==========================================
+ Hits            448        450     +2   
  Misses            9          9          
  Partials          0          0          

Powered by Codecov. Last update 11c42a0...405792d

@dead-horse
Copy link
Member

+1

@dead-horse dead-horse merged commit c2f7ecb into master Oct 13, 2016
@dead-horse dead-horse deleted the timeout-status branch October 13, 2016 08:39
@dead-horse
Copy link
Member

2.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set status to -2 when connect timeout fire
4 participants