fix: check url before request #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 98.19%@@ master #172 diff @@
==========================================
Files 1 1
Lines 382 386 +4
Methods 31 31
Messages 0 0
Branches 112 113 +1
==========================================
+ Hits 375 379 +4
Misses 7 7
Partials 0 0
|
|
每次都多了一次字符串相加… |
|
还好吧…损耗不大 |
|
if 判断，然后抛错？ Sent from my iPhone
|
| @@ -173,6 +174,8 @@ exports.requestThunk = function (url, args) { | |||
|
|
|||
| exports.requestWithCallback = function (url, args, callback) { | |||
| // requestWithCallback(url, callback) | |||
| assert(url && (typeof url === 'string' || url.constructor.name === 'Url'), | |||
There was a problem hiding this comment.
if (!url || (typeof url !== 'string' && url.constructor.name !== 'Url')) {
throw new TypeError('expect request url to be a string or an instance of Url, but got '+ url);
}考虑到这个 request 会大量调用，能省即省。
|
+1 |
|
@dead-horse 测试用例挂了
|
| @@ -210,7 +216,7 @@ exports.requestWithCallback = function (url, args, callback) { | |||
| parsedUrl = url; | |||
| } | |||
|
|
|||
| var method = (args.type || args.method || parsedUrl.method || 'GET').toUpperCase(); | |||
| var method = (args.type || args.method || 'GET').toUpperCase(); | |||
There was a problem hiding this comment.
规范一下，第一个参数只允许 string 或者 Url 对象可能会有不兼容
|
只判断 string 或者 object 了 |
|
感觉可以当做是一个 fix 了 |
dead-horse
changed the title
|
+1 |
|
2.9.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
否则后面会报错，让人没有头绪