fix: support hostname #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
reviewed
Nov 20, 2018
fengmk2
reviewed
Nov 20, 2018
lib/detect-port.js
Outdated
| if (err.code === 'EADDRNOTAVAIL') { | ||
| throw new Error('the ip that is not unkonwn on the machine'); | ||
| } else { | ||
| return handleError(); |
|
缺少对应的单元测试 |
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 92.72% 92.53% -0.19%
==========================================
Files 2 2
Lines 55 67 +12
==========================================
+ Hits 51 62 +11
- Misses 4 5 +1
Continue to review full report at Codecov.
|
fengmk2
reviewed
Nov 20, 2018
lib/detect-port.js
Outdated
| listen(port, hostname, (err, realPort) => { | ||
| if (err) { | ||
| if (err.code === 'EADDRNOTAVAIL') { | ||
| throw new Error('the ip that is not unkonwn on the machine'); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
return callback(new Error('the ip that is not unkonwn on the machine')) 应该是 callback 返回，而不是 throw error
fengmk2
approved these changes
Nov 20, 2018
|
1.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support user hostname