From 4ee939c656e6df3bafddec36667bde3114d1d950 Mon Sep 17 00:00:00 2001 From: Brant Burnett Date: Tue, 29 Oct 2024 16:52:54 -0400 Subject: [PATCH] Sealed and added internal XML doc comments --- .../NodaNullableConverter.cs | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/NodaTime.Serialization.SystemTextJson/NodaNullableConverter.cs b/src/NodaTime.Serialization.SystemTextJson/NodaNullableConverter.cs index f781bdd..89680b6 100644 --- a/src/NodaTime.Serialization.SystemTextJson/NodaNullableConverter.cs +++ b/src/NodaTime.Serialization.SystemTextJson/NodaNullableConverter.cs @@ -8,10 +8,19 @@ namespace NodaTime.Serialization.SystemTextJson; -internal class NodaNullableConverter : JsonConverter where T : struct +/// +/// System.Text.Json converter for value types, wrapping +/// an inner converter. +/// +/// Value type to be converted. +internal sealed class NodaNullableConverter : JsonConverter where T : struct { private readonly JsonConverter _innerConverter; + /// + /// Creates a new NodaNullableConverter. + /// + /// Inner converter for serializing and deserializing when not null. public NodaNullableConverter(JsonConverter innerConverter) { Preconditions.CheckNotNull(innerConverter, nameof(innerConverter)); @@ -19,6 +28,7 @@ public NodaNullableConverter(JsonConverter innerConverter) _innerConverter = innerConverter; } + /// public override T? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) { if (reader.TokenType == JsonTokenType.Null) @@ -29,6 +39,7 @@ public NodaNullableConverter(JsonConverter innerConverter) return _innerConverter.Read(ref reader, typeToConvert, options); } + /// public override void Write(Utf8JsonWriter writer, T? value, JsonSerializerOptions options) { if (value is null)