Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin iree packages in nightly shark-ai releases #929

Open
ScottTodd opened this issue Feb 7, 2025 · 0 comments
Open

Pin iree packages in nightly shark-ai releases #929

ScottTodd opened this issue Feb 7, 2025 · 0 comments
Assignees

Comments

@ScottTodd
Copy link
Member

ScottTodd commented Feb 7, 2025

I'd like for a manual QA process to be able to pip install -f https://github.com/nod-ai/shark-ai/releases/expanded_assets/dev-wheels -f https://iree.dev/pip-release-links.html shark-ai[apps]==3.2.0rc20250206 and have that match what we would release to stable at that version, including pins for all packages.

We currently only pin IREE package versions in stable shark-ai releases, not nightly releases. For example, here's is a section of the METADATA for a stable release:

Requires-Dist: iree-base-compiler==3.1.*
Requires-Dist: iree-base-runtime==3.1.*
Requires-Dist: iree-turbine==3.1.*
Requires-Dist: sharktank==3.1.0
Requires-Dist: shortfin==3.1.0
Provides-Extra: onnx
Requires-Dist: iree-base-compiler[onnx]; extra == "onnx"
Provides-Extra: apps
Requires-Dist: shortfin[apps]; extra == "apps"

Compared to a nightly release:

Requires-Dist: sharktank==3.2.0rc20250206
Requires-Dist: shortfin==3.2.0rc20250206
Provides-Extra: onnx
Requires-Dist: iree-base-compiler[onnx]; extra == "onnx"
Provides-Extra: apps
Requires-Dist: shortfin[apps]; extra == "apps"

Could we make the nightly releases look more like this instead, using versions from https://github.com/nod-ai/shark-ai/blob/main/requirements-iree-pinned.txt ?

Requires-Dist: iree-base-compiler==3.2.0rc20250206
Requires-Dist: iree-base-runtime==3.2.0rc20250206
Requires-Dist: iree-turbine==3.2.0rc20250206
Requires-Dist: sharktank==3.2.0rc20250206
Requires-Dist: shortfin==3.2.0rc20250206
Provides-Extra: onnx
Requires-Dist: iree-base-compiler[onnx]; extra == "onnx"
Provides-Extra: apps
Requires-Dist: shortfin[apps]; extra == "apps"

We had some related discussions back when adding the meta package, e.g. #475.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants