Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagram background color causes text to be unreadable (Umbra, Linux) #38

Closed
Prometheus625 opened this issue Oct 3, 2019 · 4 comments
Closed

Comments

@Prometheus625
Copy link

image

@krokofant
Copy link
Contributor

@Prometheus625 Are there more graph scenarios that look weird? Would be great to have a few more test cases.

@Prometheus625
Copy link
Author

The flowchart using flowchart.js and the sequence diagram using js-sequence both look normal. It's the mermaid charts that are strange.

Here's the example sequence diagram using mermaid:
image

Graph using mermaid:
image

Gantt using mermaid:
image

I don't know much about CSS but was able to find that changing --node-fill fixed the problem. Adding --node-fill:#1e2022; to urisine-umbra.css in :root{} worked.

Here's the mermaid flowchart after:
image

@noatpad
Copy link
Owner

noatpad commented Oct 5, 2019

Huh that's interesting. Looks like Typora uses mermaid's hardcoded, default colors. A few extra CSS rules and a bit of tinkering with those root variables oughta do the trick
image

@noatpad
Copy link
Owner

noatpad commented Oct 6, 2019

And Gantt diagrams should look a lot better now once I get a release up
image
image

@noatpad noatpad closed this as completed in 56a6126 Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants