-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove static asserts #1228
Merged
Merged
Remove static asserts #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodelrieu
force-pushed
the
remove_static_asserts
branch
from
September 6, 2018 16:21
81b0a59
to
28d2376
Compare
gregmarr
reviewed
Sep 6, 2018
theodelrieu
force-pushed
the
remove_static_asserts
branch
from
September 7, 2018 10:57
28d2376
to
3f1abad
Compare
theodelrieu
force-pushed
the
remove_static_asserts
branch
from
September 7, 2018 12:11
3f1abad
to
aea648b
Compare
To me, the PR is SFIENA magic... :-S @gregmarr Do you think the PR is OK to merge? (I do trust @theodelrieu, but I really fail to understand the individual changes...) |
Those things that I can follow look good. I guess as long as the test suite is still passing, we should be good. |
Thanks a lot! |
This was referenced Sep 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues #960.
There is some refactoring in
detail/meta
, the checks we perform were too brittle (I fixed some issues in the mean time).At some point I'd like to iron out the quirks in
meta
, (e.g.is_compatible_*
traits, etc...), but this is not the goal of this PR.I will sum up the pros/cons of this PR that can be found in detail in #960:
Pros:
nlohmann::json
is now more SFINAE-correct. The library has better interoperability with other generic libraries. (Not 100% because of operator T() considered harmful #958 though)Cons:
static_assert
, instead the compiler will yell that no constructor could be used.Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.