-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.11.2: test suite is failing in two units #3828
Comments
Did you check out the code from git? |
Tested master and it fails the same way. |
This is strange. Just that I understand: Do you check out the code from GitHub for the respective tag? The tests are expected to fail if the code is just downloaded, see https://github.com/nlohmann/json#execute-unit-tests |
No I'm downloading latest tagged source tar ball and list of commits added after that tag however effectively it is the same. URL: https://github.com/nlohmann/json/
VCS: https://github.com/nlohmann/json/
Source: %{VCS}/archive/v%{version}/%{name}-%{version}.tar.gz
Source: https://github.com/nlohmann/json_test_data/archive/v%{test_data_version}/%{name}_test_data-%{test_data_version}.tar.gz
Patch: %{VCS}/commit/4c8cdd7a.patch#/%{name}-Add-Check-amalgamation-workflow-3693.patch
Patch: %{VCS}/commit/f7973f46.patch#/%{name}-Use-official-Clang-GCC-containers-3703.patch
Patch: %{VCS}/commit/bed648ca.patch#/%{name}-Allow-custom-base-class-as-node-customization-point-.patch
Patch: %{VCS}/commit/307c053b.patch#/%{name}-Add-missing-numeric-include-3719.patch
Patch: %{VCS}/commit/58bd97e2.patch#/%{name}-Add-clang-tools-to-required-tools-for-ci_static_anal.patch
Patch: %{VCS}/commit/15ca78a8.patch#/%{name}-Add-dark-mode-toggle-to-documentation-3726.patch
Patch: %{VCS}/commit/c920f3f4.patch#/%{name}-Update-Codacy-link-3740.patch
Patch: %{VCS}/commit/9dfa7226.patch#/%{name}-Fix-typos-in-.md-files-3748.patch
Patch: %{VCS}/commit/2d1f9b6a.patch#/%{name}-Add-Bazel-build-support-3709.patch
Patch: %{VCS}/commit/3d1252bb.patch#/%{name}-Replace-limit-macros-with-std-numeric_limits-3723.patch
Patch: %{VCS}/commit/f4658de2.patch#/%{name}-Fix-declaration-hides-global-declaration-warning-375.patch
Patch: %{VCS}/commit/17d9eacd.patch#/%{name}-Add-missing-files-to-release-artifacts-3728.patch
Patch: %{VCS}/commit/4b2c8ce6.patch#/%{name}-Fix-some-typos-for-n-dimensional-arrays-3767.patch
Patch: %{VCS}/commit/a3e6e26d.patch#/%{name}-Bump-joblib-from-1.1.0-to-1.2.0-in-docs-mkdocs-3781.patch
[..]
%prep
%autosetup -p1 -a1 |
The test expects the source directory to be a git clone. |
From the
|
OK so there are more units affecter bu the same condition. Feel free to close that ticket however as test suite should not be working with dist tar ball IMO it woud be allow automatically skipp those units as there is not in build tree git meta data. |
Description
Looks like test suite is failing in two units.
Reproduction steps
cmake settings:
Expected vs. actual results
test suite should not fail
Minimal code example
Error messages
Compiler and operating system
gcc 12.2.1, Linux x86/64
Library version
3.11.2, test data version 3.1.0
Validation
develop
branch is used.The text was updated successfully, but these errors were encountered: