Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate LGTM.com installation from OAuth to GitHub App #1781

Closed
ghost opened this issue Oct 7, 2019 · 3 comments
Closed

Migrate LGTM.com installation from OAuth to GitHub App #1781

ghost opened this issue Oct 7, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Oct 7, 2019

Hi There,

This project is still using an old implementation of LGTM's automated code review, which has now been disabled. To continue using automated code review, and receive checks on your Pull Requests, please install the GitHub App on this repository.

Thanks,
The LGTM Team
@nlohmann
Copy link
Owner

When doing so, I have the following permission list:

image

Is this expected?

@s0
Copy link

s0 commented Oct 17, 2019

Yes. No special access to code is required as we only analyse open source repos, and we need to be able to write checks for pull requests.

@nlohmann
Copy link
Owner

Ok, then I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nlohmann @s0