Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static assertions for template type properties required #1729

Closed
t-b opened this issue Aug 27, 2019 · 7 comments
Closed

Static assertions for template type properties required #1729

t-b opened this issue Aug 27, 2019 · 7 comments
Labels
kind: enhancement/improvement state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated state: waiting for PR

Comments

@t-b
Copy link
Contributor

t-b commented Aug 27, 2019

While working on #1722 I realized that I'm relying on quite a few properties of NumberUnsignedType and NumberIntegerType.

These are:

  • NumberUnsignedType is an unsigned integer
  • NumberSignedType is a signed integer
  • every positive NumberSignedType can be expressed as NumberUnsignedType

Do we need static_assert enforcing that?

One could put it into basic_json::assert_invariant.

@stale
Copy link

stale bot commented Sep 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Sep 26, 2019
@stale stale bot closed this as completed Oct 3, 2019
@t-b
Copy link
Contributor Author

t-b commented Oct 3, 2019

unstale.

@nlohmann nlohmann reopened this Oct 23, 2019
@stale stale bot removed the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Oct 23, 2019
@stale
Copy link

stale bot commented Nov 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Nov 22, 2019
@t-b
Copy link
Contributor Author

t-b commented Nov 22, 2019

unstale.

@stale stale bot removed the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Nov 22, 2019
@nlohmann
Copy link
Owner

@t-b Thanks for keeping the stale bot away. However, there was no activity since August 27. Would you have time to propose a PR?

@t-b
Copy link
Contributor Author

t-b commented Nov 22, 2019

@nlohmann Yes if you think this is good idea I can propose one. I just wanted to know from you before if you think this is a good idea.

@stale
Copy link

stale bot commented Dec 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Dec 23, 2019
@stale stale bot closed this as completed Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement/improvement state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated state: waiting for PR
Projects
None yet
Development

No branches or pull requests

2 participants