Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bin/ dir for fat pybis #10

Open
njsmith opened this issue Jan 29, 2023 · 0 comments
Open

fix bin/ dir for fat pybis #10

njsmith opened this issue Jan 29, 2023 · 0 comments

Comments

@njsmith
Copy link
Owner

njsmith commented Jan 29, 2023

For universal2 pybis on macOS, we should always create two bin/ dirs -- one for running in x86-64 mode and one for running in arm64 mode -- and choose them appropriately when assembling an environment.

We already track which pybis need this and which mode we're in, inside ArtifactInfo objects -- the problem is just that both the x86-64 and arm64 ArtifactInfos have the same content hash, so they end up sharing the same entry in the EnvForest, so we need to make sure that if we fill in the entry for one ArtifactInfo then it's still usable for the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant