Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Pre-merge build results" is ambiguous: is that before or after the change? #334

Open
samuela opened this issue Feb 1, 2023 · 0 comments
Open

"Pre-merge build results" is ambiguous: is that before or after the change? #334

samuela opened this issue Feb 1, 2023 · 0 comments

Comments

@samuela
Copy link

samuela commented Feb 1, 2023 •
edited
Loading

As the title says, I've always been confused by this wording and tbh still don't understand what it means. Could this wording be clarified? "Pre-merge" could either refer to

  • "without changes merged, but prior to merging the PR", eg build results on current master, or
  • "with the changes merged, but obv the PR itself has not been merged into master yet", eg the conventional usage of nixpkgs-review

Example issue with this wording: NixOS/nixpkgs#213148.
@samuela samuela changed the title "Pre-merge build results" is ambiguous: is that before or after merging change? "Pre-merge build results" is ambiguous: is that before or after the change? Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samuela