Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Shell integration is installed even with programs.fzf.enableFishIntegration = false #5904

Open
2 tasks done
s3igo opened this issue Sep 28, 2024 · 0 comments
Open
2 tasks done
Assignees
Labels
bug triage Issues or feature request that have not been triaged yet

Comments

@s3igo
Copy link

s3igo commented Sep 28, 2024

Are you following the right branch?

  • My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

  • I have searched the existing issues

Issue description

Even when setting programs.fzf.enableFishIntegration = false, the shell integration still gets installed in the fish environment. This seems to be caused by the pkgs.fzf installing the shell integration during the postInstall phase, regardless of the contents of programs.fish.interactiveShellInit.

I was able to fix this issue with the following configuration:

programs.fzf = {
  enable = true;
  enableFishIntegration = false;
  package = pkgs.fzf.overrideAttrs {
    # Prevent shell integrations from installing automatically
    postInstall = ''
      installManPage man/man1/fzf.1
    '';
  };
};

However, I am not sure if this is the appropriate way to fix the issue. Also, I have not yet tested whether the same problem occurs in bash or zsh.

Maintainer CC

No response

System information

- system: `"aarch64-darwin"`
 - host os: `Darwin 23.6.0, macOS 14.6.1`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.7`
 - nixpkgs: `/nix/store/vyv637pn8fx0gs28pfqy5b3jkrmd7cvl-source`
@s3igo s3igo added bug triage Issues or feature request that have not been triaged yet labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Issues or feature request that have not been triaged yet
Projects
None yet
Development

No branches or pull requests

4 participants