isync/mbsync: update module for 1.5.0 changes #5918
Conversation
KarlJoad
force-pushed
the
mbsync-updates
branch
2 times, most recently
from
10c889c
to
36f99cd
Compare
mbsync 1.5.0 replaced the name of the configuration option [1]. Also update SSLVersions to TLSVersions for the same reason. Inform the user if the option was renamed. [1] https://sourceforge.net/projects/isync/files/isync/1.5.0/
mbsync 1.5.0 supports placing isync's configuration file in $XDG_CONFIG_HOME/isyncrc [1]. [1] https://sourceforge.net/projects/isync/files/isync/1.5.0/
KarlJoad
force-pushed
the
mbsync-updates
branch
from
36f99cd
to
dd04aa8
Compare
| SSLType IMAPS | ||
| SSLVersions TLSv1.3 TLSv1.2 | ||
| TLSType IMAPS | ||
| TLSVersions TLSv1.3 TLSv1.2 |
There was a problem hiding this comment.
| TLSVersions TLSv1.3 TLSv1.2 | |
| TLSVersions +1.3 +1.2 |
Sorry about the drive-by comment, but i just got bitten by this change in isync/mbsync. The SSLVersions and TLSVersions config keys don't take the same arguments, it's not a simple rename.
I have found references here https://sourceforge.net/projects/isync/files/isync/1.5.0/ and here https://isync.sourceforge.io/mbsync.html but frustratingly i haven't found actual documentation for permitted arguments. By trial and error i managed to make things work with the + as shown above.
Disclosure/disclaimer is that i'm using isync/mbsync on macOS via Homebrew – i am just making a comment here before this change wastes other people's time more than necessary. I found this PR because i was looking for working examples.
There was a problem hiding this comment.
That's a good catch! Thanks! I will have to mark SSLVersions as completely deprecated and inform the user about TLSVersions along with the +/- change, I guess.
...but frustratingly i haven't found actual documentation for permitted arguments.
I found the source file that implements this parsing (src/drv_imap.c:3788). They also support a - symbol to disable a particular version. I suspect this was an undocumented change to support isync 1.5.0's default-disabling of TLS 1.0/1.1.
I will document this in a release note. But because SSLVersions/TLSVersions is part of extraConfig, I doubt I will be able to automatically catch this misconfiguration.
There was a problem hiding this comment.
isync 1.5.0's default-disabling of TLS 1.0/1.1
This is the only reason I used SSLVersions so I could delete the line. (I probably won't, though, in case there are future changes.)
Description
Update isync to use new features in isync 1.5.0.
Closes #5884 and #3317.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allornix develop --ignore-environment .#allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC