Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox trees can't be toggled from the keyboard #67

Open
eatyourgreens opened this issue Dec 8, 2024 · 2 comments
Open

Checkbox trees can't be toggled from the keyboard #67

eatyourgreens opened this issue Dec 8, 2024 · 2 comments
Labels
accessibility bug Something isn't working

Comments

@eatyourgreens
Copy link

eatyourgreens commented Dec 8, 2024

Screen.Recording.2024-12-08.at.10.08.43.mov

Here, I'm tabbing to the checkbox tree in Chrome, then navigating it with the cursor keys. I should be able to toggle each checkbox on/off with space (or enter) but that doesn't work. I think the keyboard handler for expanding/contracting a list is overriding the handler for the checkbox control.

I fixed this in https://github.com/nismod/irv-jamaica. I'll go back and dig out the changes that I made.

@eatyourgreens eatyourgreens added bug Something isn't working accessibility labels Dec 8, 2024
@eatyourgreens
Copy link
Author

Here's a checkbox tree in https://github.com/nismod/irv-jamaica. I'm using the cursor keys to navigate the tree (left/right to open and close tree nodes, up/down to move through the tree) and space/enter to select/deselect the focused node. I think this is how a checkbox tree is expected to work from the keyboard.

Screen.Recording.2024-12-08.at.10.19.37.mov

@eatyourgreens
Copy link
Author

I think this PR fixed the keyboard handlers for the tree view, as part of an upgrade to Material UI.

This PR might also be relevant: fixing missing labels for input controls. I'm not sure that unlabelled checkboxes are a problem for the checkbox trees in the global tool.

@eatyourgreens eatyourgreens changed the title Checkbox trees can't be operated from the keyboard Checkbox trees can't be toggled from the keyboard Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant