Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdout of shell should be decoded with sys.getfilesystemencoding() #203

Conversation

doloopwhile
Copy link

Hello.

Errors are raised when $LANG is not utf-8 (ex. LANG=ja_JP.EUCJP).

This cause a bug in pip.
pypa/pip#4917

Would you review it ?

@sethmlarson
Copy link
Contributor

Hey @doloopwhile! Thanks for making this contribution, it looks like a positive change for me.
Currently it looks like our Travis build is failing for unrelated reasons, I'll see if I can fix this. 🎉

@sethmlarson
Copy link
Contributor

Also going to ping @nir0s as this issue should probably mean a new release of distro so that pip can vendor it.

@nir0s nir0s merged commit 6a440dc into python-distro:master Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants