From 844717f52b6098bb181697cb95dab7c8dbe2a91f Mon Sep 17 00:00:00 2001
From: ringabout <43030857+ringabout@users.noreply.github.com>
Date: Mon, 13 Mar 2023 03:03:46 +0800
Subject: [PATCH] fixes explicit globals in macros (#21502)

(cherry picked from commit b2c1dcbbc9b097c9c13dda4951e824cdb5f16225)
---
 compiler/vmgen.nim   |  3 ++-
 tests/vm/tvmmisc.nim | 13 +++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/compiler/vmgen.nim b/compiler/vmgen.nim
index 8a03568b8e3b7..c0e13d61b1c36 100644
--- a/compiler/vmgen.nim
+++ b/compiler/vmgen.nim
@@ -1932,7 +1932,8 @@ proc genVarSection(c: PCtx; n: PNode) =
           c.genAdditionalCopy(a[2], opcWrDeref, tmp, 0, val)
           c.freeTemp(val)
           c.freeTemp(tmp)
-        elif not importcCondVar(s) and not (s.typ.kind == tyProc and s.typ.callConv == ccClosure): # fixes #10938
+        elif not importcCondVar(s) and not (s.typ.kind == tyProc and s.typ.callConv == ccClosure) and
+                sfPure notin s.flags: # fixes #10938
           # there is a pre-existing issue with closure types in VM
           # if `(var s: proc () = default(proc ()); doAssert s == nil)` works for you;
           # you might remove the second condition.
diff --git a/tests/vm/tvmmisc.nim b/tests/vm/tvmmisc.nim
index a3f1770e5f46d..2ecf65632bc30 100644
--- a/tests/vm/tvmmisc.nim
+++ b/tests/vm/tvmmisc.nim
@@ -643,3 +643,16 @@ const b = block:
 
 doAssert a == @[@[0, 1, 2], @[0, 1, 2], @[0, 1, 2]]
 doAssert b == @[@[0, 1, 2], @[0, 1, 2], @[0, 1, 2]]
+
+macro m1(s: string): int =
+  var ProcID {.global, compileTime.}: int
+  inc(ProcID)
+  result = newLit(ProcID)
+
+proc macroGlobal =
+  doAssert m1("Macro argument") == 1
+  doAssert m1("Macro argument") == 2
+  doAssert m1("Macro argument") == 3
+
+static: macroGlobal()
+macroGlobal()