Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better implementation of for with-column (create-table) #3

Open
ukriish opened this issue May 19, 2016 · 1 comment
Open

A better implementation of for with-column (create-table) #3

ukriish opened this issue May 19, 2016 · 1 comment

Comments

@ukriish
Copy link
Contributor

ukriish commented May 19, 2016

As of now it is using sql/call to generate various constraints for columns, which shouldn't be the case as they are not really sql function calls.

Possible better implementation would be a map for each column, which can be generated using helpers.

@jkida
Copy link

jkida commented Jul 18, 2018

Is it possible to make create-table work with the example of [:kind (sql/call :varchar 10)].
Trying to execute this throws PSQLException ERROR: syntax error at or near "$1" looks like parameters can not be passed to create table.
Is this correct?

I was able to get it to working by just using sql/raw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants