Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax restriction on Sphinx version when a compatible version of sphinx gallery has been released #3916

Closed
ymzayek opened this issue Aug 17, 2023 · 7 comments · Fixed by #4081
Closed

Relax restriction on Sphinx version when a compatible version of sphinx gallery has been released #3916

ymzayek opened this issue Aug 17, 2023 · 7 comments · Fixed by #4081
Labels
Maintenance This issue is related to maintenance work.
Milestone
release 0.10.3

Comments

@ymzayek
Copy link
Member

ymzayek commented Aug 17, 2023

Sphinx 7.2.0 has just been released and caused an issue with the furo theme. This is documented in this issue on sphinx's github. Should we downgrade to sphinx 7.1.2 until this is patched?
@Remi-Gau
Copy link
Collaborator

thanks for looking into this: I would that capping the sphinx dependency at 7.1.2 until this bug is fixed makes sense.

@AA-Turner
Copy link

Please test with Sphinx 7.2.2.

A

@Remi-Gau
Copy link
Collaborator

thanks for the ping
just triggered a re run of the failed build on our main, let's see if it grabs the latest release and what happens

@Remi-Gau
Copy link
Collaborator

so far it did get the latest 7.2.2 and is building...

@Remi-Gau
Copy link
Collaborator

Ok with 7.2.2 it seems that the problem is with shpinx gallery

@Remi-Gau
Copy link
Collaborator

Related to this fix on sphinx gallery: sphinx-gallery/sphinx-gallery#1176

Will pin our sphinx version to < 7.2.0 until there is a new sphinx gallery release

@Remi-Gau Remi-Gau mentioned this issue Aug 17, 2023
Merged
@Remi-Gau
Copy link
Collaborator

Renaming this issue so we remember to check for a new release of sphinx gallery

@Remi-Gau Remi-Gau changed the title Doc build is broken due to a known issue with furo in latest Sphinx 7.2.0 release Relax restrction on Sphinx version when a compatible version of sphinx gallery has been released Aug 18, 2023
@Remi-Gau Remi-Gau changed the title Relax restrction on Sphinx version when a compatible version of sphinx gallery has been released Relax restriction on Sphinx version when a compatible version of sphinx gallery has been released Aug 18, 2023
@ymzayek ymzayek added this to the release 0.11.0 milestone Aug 24, 2023
@Remi-Gau Remi-Gau added the Maintenance This issue is related to maintenance work. label Aug 29, 2023
@Remi-Gau Remi-Gau moved this to Backlog in Nilearn Generic Oct 7, 2023
@ymzayek ymzayek mentioned this issue Oct 25, 2023
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Nilearn Generic Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance This issue is related to maintenance work.
Projects
Nilearn Generic
Status: Done
Milestone
release 0.10.3
Development

Successfully merging a pull request may close this issue.

[DOC][MAINT] Remove restriction on Sphinx version ymzayek/nilearn
3 participants
@Remi-Gau @AA-Turner @ymzayek