-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript Support for Html2Canvas Now Available #315
Comments
Thanks! This looks great, and would be glad to include them in the repo and keep them in sync with changes over time. Question: Does the TypeScript definitions allow for default values to be defined? |
I tried the above type definition, but still getting error: |
Is there a latest version of this typescript ? it appears it's not compatible with the latest html2canvas version (1.0.0 alpha versions) |
Could you please update this one either tell how to manually modify it in order to use with the next html2canvas releases if you abandoned this project. |
If anyone is interested in making a PR for including typescript definitions for html2canvas (based on the Flow types) I could merge them to this repo. |
Well i am interested, because i need it for my project. The thing is i have no idea how to do PR. If you could maybe give some good articles i will try my best. Otherwise it could take longer time for me to do the same thing. |
Hi there,
Firstly, thanks for this great library!
For anyone using TypeScript and Html2Canvas together, I have added a new TypeScript Definition file to the repository found at https://github.com/borisyankov/DefinitelyTyped
At some point it would be great to see ownership and maintenance of this definition file assumed by the project authors and included as part of the official Html2Canvas release package. This will make it easier to keep in sync with enhancements over time.
In the meantime, perhaps a link to this could be included in the official documentation?
I hope this is valuable to others.
Cheers
The text was updated successfully, but these errors were encountered: