Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in css content on safari #1993

Closed
RTFaught opened this issue Sep 4, 2019 · 1 comment · Fixed by #2018
Closed

regression in css content on safari #1993

RTFaught opened this issue Sep 4, 2019 · 1 comment · Fixed by #2018

Comments

@RTFaught
Copy link

RTFaught commented Sep 4, 2019

An issue with css content on safari was fixed by #1649. This problem now occurs in 1.0.0-rc.3
See fiddle https://jsfiddle.net/RTFaught/71jns2px/

The content string is not shown on the rendered canvas.

This failure is only on Safari on both MacOS and IOS. Both Chrome and Firefox work correctly on MacOS and elsewhere.

The original pull request says that this problem is caused by Safari not passing content in double quotes. I thought it interesting that changing the CSS line in the fiddle from
content: "AB";
to
content: '"AB"';
shows the content but surrounded by double quotes.

Specifications:

  • html2canvas version tested with: 1.0.0-rc.3
  • Browser & version: Safari 12.1.1 on MacOS 10.14.5 and Safari on IPad IOS 12.4
  • Operating system:
@RTFaught
Copy link
Author

RTFaught commented Sep 5, 2019

Perhaps this is not a regression. I cannot find a release that contains the earlier fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant