Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot render iframe content #1668

Closed
markb-trustifi opened this issue Sep 27, 2018 · 3 comments · Fixed by #1863
Closed

Cannot render iframe content #1668

markb-trustifi opened this issue Sep 27, 2018 · 3 comments · Fixed by #1863

Comments

@markb-trustifi
Copy link

markb-trustifi commented Sep 27, 2018

version: 1.0.0-alpha.12
browser: chrome 69
os: Mac

The process is stuck when I add to the rendered element one of these iframes:
<iframe src="images/logo-icon.svg"></iframe>
<iframe src="data:text/html,<p>Some HTML</p>"></iframe>

As far as I see it is stuck at function ResourceLoader.ready, line 187
Some of the promises remains pending forever and line return Promise.all(values) never reached.
If I change the original code to this one:

var values = keys.map(function (str) {
    return Promise.race([_this5.cache[str].catch(function (e) {
        if (process.env.NODE_ENV !== 'production') {
            _this5.logger.log('Unable to load image', e);
        }
        return null;
    }), new Promise(function(resolve, reject) {
        setTimeout(resolve, 5000, null);
    })]);
});

the file is rendered but the iframe area remains blank.

@orl99
Copy link

orl99 commented Oct 17, 2018

I have the same problem

@tangdw
Copy link

tangdw commented Nov 17, 2018

+1

@rzontar
Copy link

rzontar commented Feb 5, 2019

Had the same problem in Firefox 65 on Windows. 1 promise never resolved or rejected.

Our solution was to add an data-html2canvas-ignore="true" attribute to all iframes before calling html2canvas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants