Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border css is not appearing when converted to canvas with latest library file. #1349

Closed
raghav141988 opened this issue Jan 2, 2018 · 7 comments
Labels

Comments

@raghav141988
Copy link

Hi,
I was trying to experiment with html2canvas and earlier build was converting an HTML element to canvas successfully with all CSS applied, but with latest build quality of the converted canvas has improved significantly, however some of the CSS is not available in the finally converted canvas.

Working fiddle with earlier library version(https://cdn.rawgit.com/niklasvh/html2canvas/0.5.0-alpha2/dist/html2canvas.min.js) : http://jsfiddle.net/bLommeak/

Not working fiddle with latest library : http://jsfiddle.net/rjk3qqbd/.

Thanks for looking in to this.

@niklasvh niklasvh added the Bug label Jan 2, 2018
@raghav141988
Copy link
Author

Thanks for fixing this so quick ! it works fantastic 👍

@4wakened5leeper
Copy link

Is the bug back ?
http://jsfiddle.net/u8hL5tjg/

@rovanu
Copy link

rovanu commented Jul 20, 2019

Yes, the bug is back
any workaround for this bug in the last version?

@dbalders
Copy link

Looks like it might have broken in rc2. I specified rc1 and the borders show in the image.

@srinivaselp
Copy link

srinivaselp commented Aug 14, 2019

Is this issue solved? I'm using https://www.npmjs.com/package/html2pdf.js which depends on html2canvas and I have no way to alter html2canvas version directly.

Edit: I manually installed rc1, but I still have issues with border
Edit 2: I found the issue (table unable to show border) occurs only if the parent div is inline

@Thyiad
Copy link

Thyiad commented Sep 4, 2019

@dbalders It works for me, rc1 border-bottom is show in the image.

@Jerther
Copy link

Jerther commented Sep 10, 2019

Fix for rc3 is here: #1952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants