Fix using <Placeholder> and <Option> array together

[andreychev]

<Select value={ value } defaultValue={ defaultValue } onUpdate={ onChange } >
  <Placeholder>{ placeholder }</Placeholder>
  {
    options.map((o) => {
      return (<Option key={ o.id } value={ option.id } >{ option.name }</Option>);
    });
  }
</Select>

Invalid children supplied to `Belle Select`, expected an Option or Placeholder component from Belle. Check the render method of `Dropdown`.

[nikgraf]

@andreychev thx for reporting, will look into this today or tomorrow

[jpuri]

Its coming from line: Select.jsx line:62
I guess issue is that when we use above way of giving options, the type is somehow not coming correct.

One trouble is also that options.map returns an array, placeholder has been given as separate component but should have been part of array.

placeholder + array !== array

[chrisvariety]

Workaround for now: [<Placeholder>Foo bar</Placeholder>].concat(options.map(...))

[jpuri]

This has been fixed with PR #148
Soon there will be a release we well :)

[luisrudge]

any ETA on this PR? I just got bitten by this as well :)

[jpuri]

:) this should be merged and released in 1-2 days.

[nikgraf]

@luisrudge Will cut a release with this today 😄

[nikgraf]

@andreychev we cut a release today - problem solved 😄

[luisrudge]

Thanks @nikgraf and @jpuri!

[andreychev]

@nikgraf @jpuri good job, thx :)