Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner does not collapse when vertical height is too small #5561

Closed
Nightfoxy opened this issue Mar 7, 2020 · 4 comments · Fixed by #5562
Closed

Banner does not collapse when vertical height is too small #5561

Nightfoxy opened this issue Mar 7, 2020 · 4 comments · Fixed by #5562

Comments

@Nightfoxy
Copy link

Describe the bug
The top banner that contains the NS logo and action icons does not collapse when the vertical height shrinks to around 475px or less. This also impacts mobile browsers in horizontal orientation. this leaves a blank space at the top where the screen elements should be.

This issue appears to be unique for version 13. Sites on 12.x collapse properly.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Any NS site running 13.1+'
  2. Shrink the vertical window size to less than 450px.
  3. See the empty space on the top and the icons still on the top right.

Expected behavior
Like in version 12, the NS logo should disappear and the action buttons should receive a transparent background and allow the rest of the content to slide up to the top of the screen.

Screenshots
NS 13 with the issue
image

NS 12 working properly
image

Your setup information

  • What version of Nightscout? Dev-13.1.0 as of 3/5/2020
  • Is your issue specific to a browser (Firefox/Safari/Chrome?) or a device (Android phone, etc.)? No. Issue replicated on Windows Chrome 80, Windows Edge, and Android 10 Chrome

Additional context
Issue was introduced with version 13.0. I was just hoping it would go away. I've tried clearing cache, temp files, using incognito, and multiple computers. I've also replicated this issue with other user's v.13 sites.

It also makes v13 sites show up poorly in the new multi-site split view since that top real estate can't be used.
image

@sulkaharo
Copy link
Member

Ping @Bartlomiejsz - the toolbar PR caused the conditional height change of the toolbar to break.

@sulkaharo
Copy link
Member

Can you test #5562 - this should fix the behaviour

@Nightfoxy
Copy link
Author

5562 fixes this issue but introduces another. If there are more than 3 icons in the top right toolbar, one wraps in the shorter height scenario I've described.
image
image

@sulkaharo
Copy link
Member

@Nightfoxy this should now be fixed in #5562, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants