Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When in fullscreen on twitch, BTTV elements that are "sibling" elements are hidden, such as the BTTV settings menu and the BTTV emote menu. #6543

Closed
Raynr opened this issue Dec 31, 2023 · 1 comment
Labels

Comments

@Raynr
Copy link

Raynr commented Dec 31, 2023

Describe the bug

When in fullscreen on twitch, BTTV elements that are "sibling" elements are hidden, such as the settings menu and the emote menu. Other dialog menus and pop-ups from both Twitch and FrankerFaceZ still appear normally.

Steps to reproduce

I've found that this only happens when entering Twitch's fullscreen mode (using 'f' hotkey or button) and not the browser fullscreen ('f11' hotkey), for both at least the Edge and chrome browsers.

  1. Goto any live twitch channel
  2. Have the bttv browser extension installed
  3. Use the twitch "fullscreen" button of 'f' hotkey (NOT 'f11') to enter twitch fullscreen
    4a. Click the "Chat Settings" button at the bottom of the chat sidebar and then the "BTTV Settings" menu option
    4b. Or if you have the BTTV emote menu button enabled, click that button in the chat sidebar.
  4. The BTTV settings menu (4a) or the BTTV emote menu (4b) will not show. However, you will see them as soon as you exit twitch's fullscreen mode.

My debug tests point to this happening because twitch's fullscreen mode only sets the 1st child div under the

to be fullscreen, currently with a css class of "Layout-sc-1xcs6mc-0 ehcMTF", and not the full .

Since the BTTV inserted HTML div is only a "sibling" to root, and not a child of that particular fullscreened div, it is only rendered in the "backdrop" when in twitch's fullscreen mode, this invisible to the user until they exit this mode.

Other emote menus and dialogs from other extensions such as FrankerfaceZ, have their html injected inside this child div inside root, so they remain visible during fullscreen mode.

The theoretical fix for this is either to move BTTV's inserted HTML to inside that child of the root div's element, or to alter the way twitch's custom fullscreen mode works, so it would include the current structure of BTTV's HTML on Twitch's webpages.

Expected behavior

I expect the BTTV settings menu and Emote picker menu, along with all other BTTV pop-up dialogs, to remain visible when twitch's version of full screen channel viewing is enabled, and not hidden behind the full screen video.

Screenshots

HTML code of Twitch channel when Settings menu and emote menu should be visible:
BTTV_Error1_Code

View of twitch channel ("konbanmiao"), after having clicked on the BTTV emote menu button:
BTTV_Error1_Channel

In the first image, the green circle shows the HTML that is marked as visible when in Twitch's special fullscreen mode, as seen by the "::backdrop" tag in that 2nd child div inside the "body". The red Circle shows where all the BTTV HTML is. I was able to prove moving the HTML code would fix the issue myself, when I used the dev "inspect code" feature to copy & paste the BTTV emote menu HTML code into the green circled section, and I was then able to see it. I don't know of a way to automatically move and edit a private company's HTML every time I view the page. I could fix this for only myself if it were just a CSS issue, as there are browser extensions for this, but I'm hoping you BTTV will be able to fix this issue themselves.

Device information

Sys Info Property Sys Info Details
Device Desktop PC
OS Name Microsoft Windows 10 Pro for Workstations
Version 10.0.19045 Build 19045
OS Manufacturer Microsoft Corporation
System Manufacturer Micro-Star International Co., Ltd.
System Model MS-7B10
System Type x64-based PC
System SKU Default string
Processor Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz, 3600 Mhz, 8 Core(s), 16 Logical Processor(s)
BIOS Version/Date American Megatrends Inc. 1.D0, 2022-11-01
SMBIOS Version 2.8
Embedded Controller Version 255.255
BIOS Mode UEFI
BaseBoard Manufacturer Micro-Star International Co., Ltd.
BaseBoard Product MEG Z390 GODLIKE (MS-7B10)
BaseBoard Version 1.0
Platform Role Desktop
Secure Boot State On
Windows Directory C:\WINDOWS
System Directory C:\WINDOWS\system32
Boot Device \Device\HarddiskVolume4
Locale United States
Hardware Abstraction Layer Version = "10.0.19041.3636"
Time Zone Eastern Standard Time
Installed Physical Memory (RAM) 64.0 GB
Total Physical Memory 63.9 GB
Available Physical Memory 51.0 GB
Browser Microsoft Edge Version 120.0.2210.91 (Official build) (64-bit)
BTTV Ext version BetterTTV Size: 2.9 MB, Version7.5.11

Additional information

No response

@Raynr Raynr added the bug label Dec 31, 2023
@night night closed this as completed in 1081efa Jan 1, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related issues or feature requests.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant