Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect emote token #6542

Closed
ScrubN opened this issue Dec 30, 2023 · 2 comments
Closed

Incorrect emote token #6542

ScrubN opened this issue Dec 30, 2023 · 2 comments
Labels

Comments

@ScrubN
Copy link
Contributor

ScrubN commented Dec 30, 2023

Describe the bug

If a given channel has fish as an emote and an accompanying bot command !fish, any uses of the command will incorrectly be shown as the fish emote and the ! will not be present.

Steps to reproduce

  1. Send any emote but prepended by a ! (FeelsOkayMan -> !FeelsOkayMan) in Twitch chat
  2. Observe that the token is incorrectly shown as an emote

Expected behavior

The token !FeelsOkayMan should remain as the text !FeelsOkayMan

Screenshots

BTTV Enabled BTTV Disabled
image image

Device information

  • OS: Windows 10 22H2
  • Browser: Brave 1.61.104 Chromium: 120.0.6099.115 (Official Build) (64-bit)
  • Version: 7.5.11

Additional information

It should be noted that 7TV allows emote names/aliases to start with ! (for example, shigetora has emotes named !boost and !play), and should fixing this issue break tokenizing these emotes, I would prefer to keep compatibility with the emotes as this issue is very minor.

@ScrubN ScrubN added the bug label Dec 30, 2023
@night night closed this as completed in 3a17549 Jan 1, 2024
@night
Copy link
Owner

night commented Jan 1, 2024

This would actually be considered working as intended, but it looks like Twitch doesn't tokenize its own emotes any longer when surrounded by symbols. As a result, we've gone ahead and removed our support for them too.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related issues or feature requests.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants