Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include emote dimensions in endpoints related to fetching emotes #5712

Closed
occluder opened this issue Oct 31, 2022 · 2 comments
Closed

Include emote dimensions in endpoints related to fetching emotes #5712

occluder opened this issue Oct 31, 2022 · 2 comments

Comments

@occluder
Copy link

Since wide emotes have been introduced, it is no longer safe to assume that every emote will be 112x112px of size, which makes things a bit complicated for some applications as trying to allot the exact space an emote will occupy becomes unworkable.

The other emote providers already include information regarding emote dimensions, for the reason that their emotes won't always be of fixed size.

I think it's about time that bttv incorporates such information in their API, or at least with the endpoints https://api.betterttv.net/3/cached/users/twitch/{id} & https://api.betterttv.net/3/cached/emotes/global as they are by far the ones needing them the most.

@night
Copy link
Owner

night commented Jan 7, 2023

Thanks for the suggestion. We've added width and height to the emote serialization when they are not 1:1, which should make it easier to identify the correct sizing when needed.

@night night closed this as completed Jan 7, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related issues or feature requests.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants